Skip to content

C library: model rand, rand_r so as not to return negative numbers #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kroening merged 1 commit into from
Jun 16, 2021
Merged

C library: model rand, rand_r so as not to return negative numbers #6182

kroening merged 1 commit into from
Jun 16, 2021

Conversation

@tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Jun 16, 2021

The modelling remains over-approximating as we return a
non-deterministic value rather than some sequence of random numbers.
Still, we should not be returning a negative number.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
C library: model rand, rand_r so as not to return negative numbers
e595faf 
The modelling remains over-approximating as we return a
non-deterministic value rather than some sequence of random numbers.
Still, we should not be returning a negative number.
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #6182 (e595faf) into develop (0002950) will increase coverage by 7.88%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6182      +/-   ##
===========================================
+ Coverage    67.40%   75.29%   +7.88%     
===========================================
  Files         1157     1454     +297     
  Lines        95236   160796   +65560     
===========================================
+ Hits         64197   121066   +56869     
- Misses       31039    39730    +8691
Flag Coverage Δ
cproversmt2 ?
regression ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/string_container.cpp 52.94% <0.00%> (-47.06%) ⬇️
src/solvers/prop/prop.cpp 42.85% <0.00%> (-41.76%) ⬇️
src/solvers/flattening/boolbv_member.cpp 53.65% <0.00%> (-38.65%) ⬇️
src/cpp/cpp_storage_spec.cpp 65.00% <0.00%> (-35.00%) ⬇️
src/util/cmdline.h 66.66% <0.00%> (-33.34%) ⬇️
src/solvers/strings/array_pool.h 66.66% <0.00%> (-33.34%) ⬇️
src/solvers/strings/string_refinement.h 66.66% <0.00%> (-33.34%) ⬇️
...rs/strings/string_concatenation_builtin_function.h 0.00% <0.00%> (-33.34%) ⬇️
src/ansi-c/c_typecheck_base.cpp 50.54% <0.00%> (-30.35%) ⬇️
src/cbmc/c_test_input_generator.cpp 60.00% <0.00%> (-30.33%) ⬇️
... and 1433 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f847fcd...e595faf. Read the comment docs.

@kroening kroening merged commit 6397c1e into diffblue:develop Jun 16, 2021
@tautschnig tautschnig deleted the rand branch June 16, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kroening kroening kroening approved these changes

@peterschrammel peterschrammel peterschrammel approved these changes

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

Assignees

No one assigned

Labels

C Front End

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tautschnig @kroening @peterschrammel